Quick code fixes from the sudoku findings (#5, #6, #7, #15, #17, #23) - #28
Merged
Conversation
Five contained fixes surfaced by an end-to-end app build: - #5 ALTER ENTITY with comma-separated `add attribute` clauses failed to parse ("no viable alternative at input '9'"). Root cause was a missing separator in the grammar (`alterEntityAction+`), not the `default` — now `alterEntityAction (COMMA? alterEntityAction)*`. (MDLParser.g4) - #6 An `autonumber` with no seed passed `mxcli check` then failed the build CE7247 "Value cannot be empty". New MDL023 (error) in ValidateEntity flags a seedless autonumber with an actionable fix (`autonumber default 1`). - #7 An AutoX pseudo-type declared under a non-matching name (`StartedAt: autocreateddate`) is silently renamed to the fixed system member (`CreatedDate`) and can't be bound in a widget (build CE1613). New MDL022 (warning) in ValidateEntity surfaces the rename + the unbindable-member trap. - #17 `mxcli run -p <relative>` failed with MxBuild's raw "should be an absolute path" error. Resolve with filepath.Abs before handing to MxBuild. - #15/#23 A build failure in the `run --watch` loop (incl. SCSS compile errors) printed only the generic "build failed: <message>", swallowing build.Raw (the full serve /build body the cold-build path already prints). Now also print the raw detail so the real file:line surfaces in the watch output. Tests: TestValidateEntityAutonumberNeedsSeed, TestValidateEntityAutoMemberRename; bug-tests f5-alter-entity-comma.mdl (positive) and f6-autonumber-seed.fail.mdl (negative). make check-mdl green. Symptom-table rows added to fix-issue.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JXnEgoc2NQP1Y2TWMCMXC4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 2 of the sudoku findings: the contained code fixes.
ALTER ENTITYwith comma-separatedadd attributeclauses failed to parse (no viable alternative at input '9'). The real cause was a missing separator (alterEntityAction+), not thedefault— nowalterEntityAction (COMMA? alterEntityAction)*.MDLParser.g4autonumberwith no seed passedcheckthen failed the build CE7247. New MDL023 (error) flags a seedless autonumber with fixautonumber default 1.ValidateEntityStartedAt: autocreateddate) is silently renamed to the fixed system member (CreatedDate) and can't be bound in a widget (CE1613). New MDL022 (warning) surfaces the rename + the unbindable-member trap.ValidateEntityrun -p <relative>failed with MxBuild's raw "should be an absolute path". Resolve withfilepath.Absfirst.cmd_run.gorun --watchloop (incl. SCSS errors likeExpected expression. _x.scss 180:35) printed only the genericbuild failed: <message>, swallowingbuild.Raw(the full serve body the cold path already prints). Now the raw detail is surfaced in the watch output too.runlocal.goTests
TestValidateEntityAutonumberNeedsSeed,TestValidateEntityAutoMemberRenamef5-alter-entity-comma.mdl(positive),f6-autonumber-seed.fail.mdl(negative)make check-mdlgreen; symptom-table rows added tofix-issue.mdNote: the #6/#7 doc examples (
autonumberseeds, canonical AutoX names) are corrected in the docs PR (#26); the two PRs are consistent across merge order. (#3/#4/#8 were docs-only; #9-check was already correct — see #26.)🤖 Generated with Claude Code
Generated by Claude Code