Skip to content

🧹 Refactor: Extract listModelFiles function into a shared utility module - #11

Merged
akutuva21 merged 1 commit into
masterfrom
fix/extract-listmodelfiles-7277451205665425511
Apr 13, 2026
Merged

akutuva21 merged 1 commit into
masterfrom
fix/extract-listmodelfiles-7277451205665425511

Conversation

@akutuva21

Copy link
Copy Markdown
Owner

🎯 What: Extracted the duplicated listModelFiles function from scripts/generate-manifest.js and scripts/validate-metadata.js into a shared utility module (scripts/utils.js).
💡 Why: To improve code maintainability and adhere to DRY principles by removing duplicated code.
✅ Verification: Ran node --test to ensure tests passed. Executed node scripts/generate-manifest.js and node scripts/validate-metadata.js to confirm both scripts continue to work correctly after the refactoring.
✨ Result: Code duplication is eliminated and the scripts successfully utilize the shared module without loss of functionality.


PR created automatically by Jules for task 7277451205665425511 started by @akutuva21

Extracted the duplicated listModelFiles function from scripts/generate-manifest.js and scripts/validate-metadata.js into a shared utility module (scripts/utils.js). This improves code maintainability and adheres to DRY principles.

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@akutuva21 akutuva21 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in sequence. listModelFiles extraction to scripts/utils.js is clean and behavior-preserving.

@akutuva21
akutuva21 merged commit 0b5dd07 into master Apr 13, 2026
1 check passed
@akutuva21
akutuva21 deleted the fix/extract-listmodelfiles-7277451205665425511 branch April 13, 2026 15:25
akutuva21 pushed a commit that referenced this pull request Apr 13, 2026
Fix to certain models so they properly simulate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant