🧹 Refactor: Extract listModelFiles function into a shared utility module - #11
Conversation
Extracted the duplicated listModelFiles function from scripts/generate-manifest.js and scripts/validate-metadata.js into a shared utility module (scripts/utils.js). This improves code maintainability and adheres to DRY principles. Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
akutuva21
left a comment
There was a problem hiding this comment.
Reviewed in sequence. listModelFiles extraction to scripts/utils.js is clean and behavior-preserving.
Fix to certain models so they properly simulate
🎯 What: Extracted the duplicated
listModelFilesfunction fromscripts/generate-manifest.jsandscripts/validate-metadata.jsinto a shared utility module (scripts/utils.js).💡 Why: To improve code maintainability and adhere to DRY principles by removing duplicated code.
✅ Verification: Ran
node --testto ensure tests passed. Executednode scripts/generate-manifest.jsandnode scripts/validate-metadata.jsto confirm both scripts continue to work correctly after the refactoring.✨ Result: Code duplication is eliminated and the scripts successfully utilize the shared module without loss of functionality.
PR created automatically by Jules for task 7277451205665425511 started by @akutuva21