Skip to content

🧹 Code Health: Remove unused getIgnoreDirs function and associated dead code - #124

Merged
akutuva21 merged 4 commits into
masterfrom
fix-unused-getignore-dirs-13203728183734872069
Jun 2, 2026
Merged

akutuva21 merged 4 commits into
masterfrom
fix-unused-getignore-dirs-13203728183734872069

Conversation

@akutuva21

Copy link
Copy Markdown
Owner

🎯 What: Removed unused code from scripts/generate-manifest.js:

  • getIgnoreDirs function
  • isIgnoredDir function
  • DEFAULT_IGNORE_DIRS constant

💡 Why: These elements were dead code and completely unused within the file. Removing them reduces clutter and improves readability and maintainability for future developers.

✅ Verification:

  • Used git diff to ensure only the unused code was removed.
  • Ran node --test to ensure no existing functionality was broken (existing test failures are known issues unrelated to this change).
  • Checked for external usages across the repository.

✨ Result: A cleaner generate-manifest.js file with 24 fewer lines of dead code.


PR created automatically by Jules for task 13203728183734872069 started by @akutuva21

Removed the `getIgnoreDirs` function, its associated `isIgnoredDir` function, and the `DEFAULT_IGNORE_DIRS` constant from `scripts/generate-manifest.js` as they were entirely unused. This improves the file's maintainability.

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@akutuva21
akutuva21 marked this pull request as ready for review June 2, 2026 14:58
@akutuva21
akutuva21 merged commit e0abed4 into master Jun 2, 2026
@akutuva21
akutuva21 deleted the fix-unused-getignore-dirs-13203728183734872069 branch June 2, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant