🔒 fix: prevent path traversal on input file read - #128
Conversation
Fixes a critical security vulnerability where the `input` argument to `scripts/apply-gallery-assignments.js` was passed directly to `fs.promises.readFile()`, allowing for arbitrary file read via path traversal (e.g. `../../../../etc/passwd`). The `input` is now sanitized using the `safeJoin` utility function, which validates that the resulting path remains within the base directory (`process.cwd()`) and throws an explicit error if a path traversal attempt is detected. Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Fixed a path traversal vulnerability in
⚠️ Risk: If left unfixed, an attacker could potentially exploit this to read arbitrary files from the system executing the script by supplying a payload like
scripts/apply-gallery-assignments.jswhere the user-providedinputargument was not validated before being passed tofs.readFile.--input ../../../../etc/passwd.🛡️ Solution: Used the existing
safeJoinutility function imported from./utils.jsto securely combine the current working directory (process.cwd()) and the user-providedinput.safeJoinnatively validates that the resolved path does not traverse outside the intended base directory, throwing aPath traversal security risk detectederror if traversal is attempted.PR created automatically by Jules for task 10377525129266671774 started by @akutuva21