Repository navigation
Fix hack in Disturb_rate function by using exact step function - #20
Conversation
Replaced the steep sigmoid approximation in the `Disturb_rate()` function with a true step function using a BNGL `if` statement: `if(t > disturb_time, disturb_mag, 0)`. Tested via `bionetgen run` to verify that the cvode solver smoothly handles the discontinuous function without failing. Also removed the obsolete comment about the hack. Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Replaced the steep sigmoid approximation in the
Disturb_rate()function with a true step function using a BNGLifstatement:if(t > disturb_time, disturb_mag, 0). Tested viabionetgen runto verify that the cvode solver smoothly handles the discontinuous function without failing. Also removed the obsolete comment about the hack.PR created automatically by Jules for task 541052412947067788 started by @akutuva21