Skip to content

🧪 Add tests for normalizeModelKey - #35

Merged
akutuva21 merged 2 commits into
masterfrom
test-normalize-model-key-18159973778207655746
May 3, 2026
Merged

akutuva21 merged 2 commits into
masterfrom
test-normalize-model-key-18159973778207655746

Conversation

@akutuva21

Copy link
Copy Markdown
Owner

🎯 What: The testing gap for the normalizeModelKey utility function in scripts/validate-metadata.js was addressed. The function is now explicitly exported and tested.
📊 Coverage: The new test suite covers the following scenarios:

  • Case-insensitive removal of .bngl extensions
  • Stripping of non-alphanumeric characters
  • Conversion of input to lowercase
  • Edge cases including empty strings, null, and undefined
    ✨ Result: Test coverage for validate-metadata.js is improved, ensuring the model key normalization logic is robust and preventing future regressions.

PR created automatically by Jules for task 18159973778207655746 started by @akutuva21

- Exported `normalizeModelKey` from `scripts/validate-metadata.js`.
- Added a full test suite for `normalizeModelKey` in `scripts/tests/validate-metadata.test.js` covering case conversion, extension stripping, sanitization of special characters, and edge cases.

Co-authored-by: akutuva21 <44119804+akutuva21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@akutuva21
akutuva21 marked this pull request as ready for review May 3, 2026 18:41
@akutuva21
akutuva21 merged commit 252da91 into master May 3, 2026
1 check passed
@akutuva21
akutuva21 deleted the test-normalize-model-key-18159973778207655746 branch May 3, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant