Repository navigation
feat: scoped Kubernetes operation declarations (ALIEN-726) - #592
Merged
lilienblum merged 3 commits intoSep 10, 2026
Merged
Conversation
lilienblum
marked this pull request as ready for review
September 8, 2026 08:31
Greptile SummaryAdds versioned Kubernetes permission declarations for operations and compiles validated custom requirements into scoped operator RBAC.
Confidence Score: 5/5The PR appears safe to merge with no outstanding findings. No new actionable issue was introduced after the previous review, and the prior malformed-identifier thread was manually resolved after the validator was tightened.
|
| Filename | Overview |
|---|---|
| crates/alien-operations-sdk/src/kubernetes.rs | Defines and validates versioned Kubernetes operation permission declarations; the prior identifier-validation finding is resolved. |
| crates/alien-operations-sdk/src/manifest.rs | Integrates optional Kubernetes permissions into operation manifest parsing and semantic validation. |
| crates/alien-helm/src/generator.rs | Merges validated custom permissions with built-in RBAC under stable scope keys and permission ceilings. |
| crates/alien-helm/tests/generator/operator_manifest_tests.rs | Covers scoped rendering, deduplication, permission ceilings, malformed declarations, and YAML attribution safety. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Manifest[Operation manifest] --> Validate[SDK permission validation]
Validate --> Enabled[Enabled custom operations]
Enabled --> Ceiling[Diagnostics or remediation ceiling]
Builtins[Built-in and baseline grants] --> Merge[Stable scoped grant merge]
Ceiling --> Merge
Merge --> Scope{Installation scope}
Scope -->|Namespace| Role[Kubernetes Role]
Scope -->|Cluster| ClusterRole[Kubernetes ClusterRole]
Reviews (3): Last reviewed commit: "chore: merge main after Kubernetes RBAC ..." | Re-trigger Greptile
Base automatically changed from
dan/alien-675-kubernetes-rbac-generator
to
main
September 8, 2026 09:57
lilienblum
force-pushed
the
dan/alien-726-kubernetes-permission-declarations
branch
from
September 10, 2026 07:38
596e6ef to
5880814
Compare
lilienblum
deleted the
dan/alien-726-kubernetes-permission-declarations
branch
September 10, 2026 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements ALIEN-726 on
main.kubernetesPermissionsdeclarations to public operation manifests.scalepatches; rejects wildcards, Secrets, privilege-bearing subresources, and broader writes.resourceNames.Review repairs
Validation now rejects YAML line breaks in attribution and malformed Kubernetes API groups/resources, including subresource identifiers. Built-in groups, supported subresources, ordinary Unicode text, and named-resource behavior remain supported.
Verification
cargo test -p alien-operations-sdk -p alien-helm --quiet: 82 unit/integration tests plus 1 doctest.cargo fmt --check, focused Clippy, docs, andgit diff --checkpassed.$pr-reviewpassed at exact head596e6ef8c038aa07185a8ac27939c82a5d8e2597with no material findings.No live EKS/GKE/AKS claim is made.