fix: retry failed generated CLI teardown

[alongubkin]

Summary

• request a new delete attempt when setup-owned teardown previously failed
• keep teardown-required idempotent while work is still active
• preserve the tracked deployment until teardown succeeds

Validation

• cargo test -p alien-deploy-cli failed_setup_teardown_requests_a_new_delete_attempt
• real generated CLI retry against a failed AWS setup: the API re-armed the same delete operation, the CLI resumed from the failed Aurora delete state, removed the remaining IAM resources, and completed successfully
• verified no IAM roles, IAM policies, Aurora clusters, Aurora instances, or DB subnet groups remained for the deployment prefix

Linear: ALIEN-793

[alongubkin]

@greptileai Please review the current head.

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge; the combined teardown retry and lease-renewal lifecycle is coherent and has focused coverage.

Summary

• Requests deletion again for teardown-failed, while preserving idempotent handling of active teardown-required work.
• Extracts reusable lease-renewal handling and applies it to setup teardown.
• Retains the last stack checkpoint while provider deletion is in flight so lease-loss cancellation can resume safely.
• Adds focused lifecycle tests for teardown retry ordering and lease renewal.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CLI down] --> B{Deployment status}
    B -->|teardown-required| D[Acquire existing setup teardown]
    B -->|teardown-failed or other| C[Request cleanup / re-arm operation]
    C --> D
    D --> E[Run setup teardown]
    E --> F[Renew lease periodically]
    E --> G[Clone retained stack checkpoint]
    G --> H[Execute provider deletion step]
    H -->|Success| I[Persist next checkpoint]
    H -->|Failure| J[Mark teardown failed]
    F -->|Lease lost| K[Cancel operation and retain prior checkpoint]
    I --> L{Teardown complete?}
    L -->|No| G
    L -->|Yes| M[Final reconcile and release]

Loading

_{Reviews (4) · Last reviewed commit: "fix: renew setup teardown leases (#621)"}

[alongubkin]

@greptileai Please review the current head. The retry test now exercises the request-to-acquisition sequence, and the lifecycle comment reflects the API re-arming the canonical failed delete operation.

[alongubkin]

@greptileai

[alongubkin]

@greptileai Please review the current head after the stacked lease-renewal PR merged into this branch. Both changes have focused lifecycle coverage; please assess the combined diff.