Skip to content

test: use resource-scoped operations permission - #625

Merged
alongubkin merged 1 commit into
mainfrom
alon/alien-798-fix-operations-permission-test
Sep 14, 2026
Merged

alongubkin merged 1 commit into
mainfrom
alon/alien-798-fix-operations-permission-test

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

  • make the operations permissions test use a real permission set with the resource binding the command requires
  • keep stack-only permission sets correctly rejected by the production generator

Root cause

The test selected the first permission set with any AWS configuration. observe/observe is valid but stack-only, while alien operations permissions intentionally generates a policy for BindingTarget::Resource. Registry ordering therefore made the test exercise an unsupported scope.

Validation

  • cargo test -p alien-cli commands::operations::permissions::tests --lib (4 passed)
  • git diff --check

Linear: ALIEN-798

@alongubkin

Copy link
Copy Markdown
Member Author

@greptileai please review the current head.

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge because the selected permission set exists, contains AWS grants, and supports the resource binding exercised by the test.

Summary

  • Replaces registry-order-dependent fixture selection with postgres/heartbeat.
  • Preserves rejection of stack-only permission sets while exercising successful resource-scoped policy generation.

Reviews (1) · Last reviewed commit: "test: use resource-scoped operations per..."

@alongubkin
alongubkin merged commit 08adb57 into main Sep 14, 2026
21 checks passed
@alongubkin
alongubkin deleted the alon/alien-798-fix-operations-permission-test branch September 14, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant