Repository navigation
perf: isolate permission types from core - #647
Merged
Merged
Conversation
|
Member
Author
|
@greptileai The P1 release finding is fixed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alien_core::permissionsto preserve public paths and type identityalien-corefor the hostImpact
Controlled empty-target
cargo check -p alien-permissions --timings:alien-core: 8.2s -> removedThe target
alien-corecheck remains and compiled once, as expected.Compatibility
alien_core::permissions::*and crate-root re-exports remain availablealien-core/openapiforwards schema derivation to the extracted typesValidation
cargo test -p alien-permissions(159 tests plus docs)cargo test -p alien-core --lib permissionscargo check -p alien-core --features openapicargo test -p alien-permission-types --features openapicargo package -p alien-permission-types --allow-dirty --no-verify --listcargo tree -p alien-permissions --edges buildcontains noalien-coregit diff --checkLinear: ALIEN-863