Repository navigation
feat: list machines for every deployment - #670
Merged
Merged
Conversation
alongubkin
force-pushed
the
alon/alien-889-universal-machine-inventory-cli
branch
from
September 18, 2026 05:11
712c90d to
592526c
Compare
alongubkin
force-pushed
the
alon/alien-889-universal-machine-inventory-cli
branch
from
September 18, 2026 05:16
592526c to
9a8c4ad
Compare
|
This comment has been minimized.
This comment has been minimized.
alongubkin
enabled auto-merge (squash)
September 18, 2026 05:30
Member
Author
|
@greptileai re-comment |
alongubkin
force-pushed
the
alon/alien-889-universal-machine-inventory-cli
branch
from
September 18, 2026 05:43
991c6a6 to
e19b20e
Compare
alongubkin
deleted the
alon/alien-889-universal-machine-inventory-cli
branch
September 18, 2026 05:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
alien deployments machinesis the developer-facing inventory command, but it called a Platform endpoint restricted toplatform=machines. That made the command fail for ordinary AWS/GCP/Azure deployments even though their ComputeClusters are managed by Horizon and have machine inventory.Depends on alienplatform/platform#722.
Root cause
The CLI consumed the old provisioning-specific SDK operation (
list_machines_inventory). The API contract now models inventory as a deployment observation and aggregates every Horizon-backed ComputeCluster.Change
GET /v1/deployments/{id}/machinesthrough the generated Rust SDK.Clusterresource ID in human output, making multi-ComputeCluster deployments unambiguous.clusterResourceIddata in--jsonoutput.No new top-level CLI or Horizon/horizond endpoint is introduced. The user command remains:
Reproduction
Before platform#722 and this PR:
against an AWS deployment returns
MACHINES_DEPLOYMENT_UNAVAILABLEbecause the old API checks that the deployment platform ismachines.After both PRs, the same command returns all machines across the deployment's ComputeClusters.
Verification
cargo build -p alien-platform-apigeneratesDeploymentMachineandlist_deployment_machinesfrom the committed OpenAPI.cargo check -p alien-clicargo test -p alien-cli machines_inventory_tests --lib