Skip to content

fix: reject incompatible worker architectures - #686

Merged
alongubkin merged 2 commits into
mainfrom
alon/alien-920-reject-worker-compute-architecture-conflicts
Sep 23, 2026
Merged

alongubkin merged 2 commits into
mainfrom
alon/alien-920-reject-worker-compute-architecture-conflicts

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

  • include the AWS Worker fixed arm64 requirement in release target planning
  • reject Worker/x86 compute conflicts before artifact building or deployment mutation
  • preserve Worker-only, compatible compute, compute-only, and non-AWS behavior

Validation

  • cargo nextest run -p alien-build plan::tests --no-fail-fast (18 passed)
  • git diff --check

Linear: ALIEN-920

@greptile-apps

greptile-apps Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previous release-path validation bypass is fully fixed and no new actionable failures remain.

Summary

The PR makes release target planning account for AWS Workers’ fixed arm64 requirement and rejects incompatible Worker/compute architectures before build work begins.

  • Resolves one compatible architecture across Worker and compute resources.
  • Enforces the architecture contract in the shared build_stack entry point, covering release auto-builds and direct library callers.
  • Adds regression coverage for Worker-only, compatible, conflicting, and early-failure paths.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Build stack] --> B[Inspect platform and resources]
    B --> C{AWS Worker present?}
    C -- Yes --> D[Require arm64]
    C -- No --> E[Resolve compute or platform architecture]
    D --> F{Compute requires x86_64?}
    F -- Yes --> G[Reject before preflights or artifacts]
    F -- No --> H[Validate requested target]
    E --> H
    H -- Mismatch --> G
    H -- Compatible --> I[Run preflights and build]
Loading

Reviews (2) · Last reviewed commit: "fix: validate architecture in shared bui..."

Comment thread crates/alien-build/src/plan.rs
@alongubkin

Copy link
Copy Markdown
Member Author

@greptileai review

@alongubkin
alongubkin merged commit dbf1e06 into main Sep 23, 2026
22 checks passed
@alongubkin
alongubkin deleted the alon/alien-920-reject-worker-compute-architecture-conflicts branch September 23, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant