Skip to content

fix: redact deployment inputs from diagnostics - #698

Merged
alongubkin merged 1 commit into
mainfrom
alon/alien-914-redact-deployment-input-values
Sep 23, 2026
Merged

alongubkin merged 1 commit into
mainfrom
alon/alien-914-redact-deployment-input-values

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

  • redact stored stack input IDs and values from DeploymentRecord debug output
  • redact user-provided environment variable names and values from the same diagnostic boundary
  • preserve operational fields needed to diagnose deployment state

This is a focused safety prerequisite for ALIEN-914. It does not add secret persistence or local input injection.

Validation

  • cargo fmt --check --package alien-manager
  • cargo test -p alien-manager deployment_debug_redacts_sensitive_values --lib
  • git diff --check

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no actionable correctness, security, or repository-rule violations identified.

Summary

This PR strengthens the diagnostic boundary for stored deployments without changing serialization or deployment behavior.

  • Redacts stack input identifiers and values from DeploymentRecord debug output.
  • Redacts user-provided environment-variable names and values while preserving whether the optional field is present.
  • Adds a regression test confirming representative secrets and identifiers are absent from formatted diagnostics.

Reviews (1) · Last reviewed commit: "fix: redact deployment inputs from diagn..."

@alongubkin
alongubkin merged commit ed32b66 into main Sep 23, 2026
22 checks passed
@alongubkin
alongubkin deleted the alon/alien-914-redact-deployment-input-values branch September 23, 2026 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant