Repository navigation
feat: allow machines join to advertise an endpoint IP - #732
Merged
Merged
Conversation
|
alongubkin
force-pushed
the
alon/alien-1024-machines-join-public-ip
branch
from
September 25, 2026 16:31
76c8b65 to
5f341b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
join --public-ip <IP>to the Machines CLI for hosts whose endpoint address cannot be inferred from their outbound connection, including hosts reachable through a VPN.This is separate from
deploy --public-endpoint, which supplies a complete URL for externally managed ingress. The new flag controls the machine address reported to the control plane for managed endpoint DNS.The override is written to the machine configuration, saved across rejoins, and can be cleared with
--public-ip auto. Changing it reconfigures the existing service without reinstalling the bundle. A bundle that lacks thepublicIpconfig entry fails clearly instead of silently ignoring the flag.Credential recovery now applies a pending configuration change after refreshing machine credentials. Bundle support is checked before changing the join token.
The PR also repairs a pnpm lockfile mismatch introduced on
mainby the Node types update in #733. Without this repair, the PR's Rust and TypeScript CI jobs both fail during frozen dependency installation, before tests run.Verification
cargo fmt --all --checkcargo test -p alien-deploy-cli --lib(170 passed)pnpm install --frozen-lockfile --lockfile-onlyRollout
Publish a machine bundle whose manifest has the optional
publicIpconfig entry before using the flag. Then publish a generated CLI package containing this change. Verify on a Machines host that its heartbeat reports the chosen address and that the endpoint DNS points there.Linear: ALIEN-1024