Skip to content

feat(cli): enable remote-sandbox without flags uses the platform's default image - #753

Merged
ItamarZand88 merged 3 commits into
mainfrom
itamar/alien-1049-give-remote-sandboxes-a-default-base-image-so-enabling-it-is
Sep 28, 2026
Merged

ItamarZand88 merged 3 commits into
mainfrom
itamar/alien-1049-give-remote-sandboxes-a-default-base-image-so-enabling-it-is

Conversation

@ItamarZand88

Copy link
Copy Markdown
Contributor

Summary

alien projects capabilities enable remote-sandbox no longer requires --image or --src. With neither, the platform keeps the saved image or uses its default, and --max-session-lifetime-seconds is optional too.

  1. The CLI always sends the lifetime (flag, else the saved value, else 3600) and carries the saved Azure config.
  2. With no image flag it sends no baseImage, so the server decides.
  3. --image and --src work as before.

This PR changes a bare enable remote-sandbox from an error to enabling with the default image.

How I tested

  • cargo test -p alien-cli --lib projects: 21/21.
  • The built binary against a mock server that logs requests: fresh project → {"maxLifetimeSeconds":3600}; saved AWS+Azure → Azure carried, saved lifetime kept; Azure-only → AWS added, Azure kept; a lifetime over the cap is refused before any request.

@greptile-apps

greptile-apps Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Changes sandbox image selection logic in the CLI.

The PR appears safe to merge; no new actionable issue was established.

Summary

The PR lets Remote Sandbox be enabled without image or lifetime flags, preserving saved Azure settings and lifetime while leaving image selection to the platform.

  • Since the previous review, it adds a mock-server test of the saved-settings read-to-write flow.

Reviews (2) · Last reviewed commit: "test(cli): cover bare remote-sandbox ena..."

Comment thread crates/alien-cli/src/commands/platform/projects.rs
@ItamarZand88

Copy link
Copy Markdown
Contributor Author

@greptile review

@ItamarZand88
ItamarZand88 merged commit 58f4d84 into main Sep 28, 2026
22 checks passed
@ItamarZand88
ItamarZand88 deleted the itamar/alien-1049-give-remote-sandboxes-a-default-base-image-so-enabling-it-is branch September 28, 2026 10:17
alongubkin added a commit that referenced this pull request Oct 5, 2026
…'s changelog (#876)

## What

Two release-flow bugs that would hit the next stable release:

1. **The next version PR fails "Release qualification".** Prepare now
bumps `infra/helm/alien-manager/Chart.yaml` and
`infra/aws-ecs-manager/variables.tf`, but the detect step's file
allowlist in `release-qualification.yml` doesn't list them, so it fails
with "Release PR contains non-version files".
2. **Each GitHub release body lists the previous release's changes.**
`generate-changelog` runs `git-cliff --latest` before the new tag
exists, so it renders the range ending at the previous tag. The v3.3.26
body lists #707–#756, which shipped in v3.3.25.

## How

1. Add both files to the allowlist, and normalize their version fields
(`version`/`appVersion` in the chart, the `alien-manager:v…` image
default in the module) so any other change to them still fails the
check.
2. Use `--unreleased --tag v<version>`: the commits since the last tag,
rendered under the new version.

## Verification

- On a scratch commit that applies prepare's own `sed` bumps for 3.3.27
to `main`: the old allowlist rejects exactly the two files; the new
allowlist and the metadata check pass. A second scratch commit that also
changes `type:` in the chart and the image registry in the module fails
with "Release PR changes non-version metadata".
- `git-cliff 2.14.2` with `cliff.toml` on `main`: `--latest` renders
#753–#779 (the v3.3.26 range); `--unreleased --tag v3.3.27` renders
#553–#873, the 68 commits since v3.3.26.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant