Repository navigation
fix: list failed preflight checks in CLI errors - #788
Merged
alongubkin merged 4 commits intoSep 30, 2026
Merged
alongubkin merged 4 commits into
alongubkin merged 4 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
alongubkin
deleted the
alon/alien-1106-cli-shows-validation-failed-with-n-errors-without-the-failed
branch
September 30, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ALIEN-1106.
Problem
When stack preflights fail, the text output said only:
The failed checks themselves are in the
ValidationFailederror'sresults, which the human error renderer never printed. Finding out what failed needed--jsonand walking the nestedresults[].errorsarrays.Fix
render_human_error(used for every CLI error in text mode) now finds the first error in the chain that carries preflightresults, and prints each failed check's errors underFailed checks:, the same way it already printsBuild output:for image build failures. JSON output is unchanged.alien renderflattened the preflight error to text, which dropped the results. It now keeps the preflight error as the source (the top-level message is unchanged), so render failures list the checks too.The added section, from the test:
Tests
render_human_error_lists_every_failed_preflight_check: a realalien_preflightsValidationFailederror with three check results (one passing), wrapped in a CLI error, renders both failed checks' messages in order.failed_render_preflights_list_the_failed_checks: the real AWS render preflights on a stack with a Frozen container list that check's message (fails with the old conversion).cargo test -p alien-cli --lib -- render ui::passes.🤖 Generated with Claude Code