Repository navigation
fix: name each failed resource in CLI deployment errors - #805
Merged
alongubkin merged 2 commits intoOct 1, 2026
Merged
alongubkin merged 2 commits into
alongubkin merged 2 commits into
Conversation
|
Member
Author
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
alongubkin
force-pushed
the
alon/alien-1122-cli-deployment-failures-dont-name-the-failed-resources
branch
from
October 1, 2026 00:00
1c1d273 to
8bc52f1
Compare
alongubkin
deleted the
alon/alien-1122-cli-deployment-failures-dont-name-the-failed-resources
branch
October 1, 2026 09:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ALIEN-1122.
Problem
When a deployment fails,
alien deployments getand deploy failure output showed only the summary:The failed resources and their errors are in the
DEPLOYMENT_FAILEDerror'scontext.resource_errors, whichrender_human_errornever read. Finding out which resource failed, and why, meant fetching the deployment as JSON and walking the nested errors.alien devalready had this logic (deployment_error_message/root_cause_message), but only for its own status card.Fix
render_human_errorfinds aDEPLOYMENT_FAILEDerror in the chain and adds aFailed resources:section with oneresource: root causeline per failed resource. The root cause is the deepest non-internal message in that resource's error chain.alien deployandalien destroyreturned a new phase-levelDEPLOYMENT_FAILED("provisioning failed") with no details. They now attach the final deployment state's headline error, which lists the failed resources, as its source.lib.rsintoui.rs, andalien devuses the same function, so there's one copy.Tests
render_human_error_names_each_failed_resource: a realalien_deploymentDeploymentFailederror with two failed resources, serialized and read back the waydeployments getreads the stored error, renders both resources with their root cause, both as stored and wrapped the wayalien deployreturns it.cargo test -p alien-cli --libpasses (341 tests).🤖 Generated with Claude Code