Skip to content

fix: accept vault --deployment after the subcommand - #807

Merged
alongubkin merged 2 commits into
mainfrom
alon/alien-1124-alien-vault-rejects-deployment-after-the-subcommand-as-its
Sep 30, 2026
Merged

alongubkin merged 2 commits into
mainfrom
alon/alien-1124-alien-vault-rejects-deployment-after-the-subcommand-as-its

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Fixes ALIEN-1124.

Problem

--deployment was declared on the vault parent command without global = true, so it was only accepted before the subcommand. The remote command's own help shows it after:

alien vault set --deployment my-deployment customer-secrets GITHUB_TOKEN ghp_xxx

and that, like alien dev vault list --deployment …, failed with unexpected argument '--deployment'.

Fix

  • alien dev vault: --deployment is global (default default, unchanged).
  • alien vault: --deployment is global too. clap refuses a required global argument, so it's now an Option that the task checks, failing with a validation error when it's missing, as before.

Tests

  • New vault_deployment_flag_parses_after_the_subcommand: alien vault set --deployment my-deployment … and alien dev vault list --deployment my-deployment … parse and carry the deployment.
  • cargo test -p alien-cli --lib passes.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Changes how the vault command parses its deployment flag.

The PR appears safe to merge; no new actionable issues or outstanding previous findings remain.

Summary

The PR makes --deployment available after local and remote vault subcommands, and moves remote missing-flag validation ahead of credential resolution.

  • Parsing tests cover the new flag position and the missing-flag error.

Reviews (2) · Last reviewed commit: "fix: report a missing vault --deployment..."

Comment thread crates/alien-cli/src/commands/vault.rs Outdated
Comment thread crates/alien-cli/src/lib.rs
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@alongubkin

Copy link
Copy Markdown
Member Author

@greptileai

@alongubkin
alongubkin merged commit 76bc4d4 into main Sep 30, 2026
22 checks passed
@alongubkin
alongubkin deleted the alon/alien-1124-alien-vault-rejects-deployment-after-the-subcommand-as-its branch September 30, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant