Repository navigation
fix: accept vault --deployment after the subcommand - #807
Merged
alongubkin merged 2 commits intoSep 30, 2026
Merged
alongubkin merged 2 commits into
alongubkin merged 2 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
Author
alongubkin
deleted the
alon/alien-1124-alien-vault-rejects-deployment-after-the-subcommand-as-its
branch
September 30, 2026 15:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ALIEN-1124.
Problem
--deploymentwas declared on thevaultparent command withoutglobal = true, so it was only accepted before the subcommand. The remote command's own help shows it after:and that, like
alien dev vault list --deployment …, failed withunexpected argument '--deployment'.Fix
alien dev vault:--deploymentis global (defaultdefault, unchanged).alien vault:--deploymentis global too. clap refuses a required global argument, so it's now anOptionthat the task checks, failing with a validation error when it's missing, as before.Tests
vault_deployment_flag_parses_after_the_subcommand:alien vault set --deployment my-deployment …andalien dev vault list --deployment my-deployment …parse and carry the deployment.cargo test -p alien-cli --libpasses.🤖 Generated with Claude Code