Repository navigation
fix: resolve a deployment group by name in the manager's list filter - #812
Merged
alongubkin merged 2 commits intoOct 1, 2026
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
alongubkin
deleted the
alon/alien-1146-manager-cant-resolve-a-deployment-by-group-name-groupname
branch
October 1, 2026 23:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ALIEN-1146.
Problem
The CLI resolves a
<group>/<name>deployment spec by listing deployments withdeploymentGroupId=<group>&name=<name>(deployment_resolver.rs). The platform API accepts a group name in that parameter; alien-manager compared it literally against group ids.alien devcreates its group namedlocal-devunder a generateddg_…id, soalien dev deployments get local-dev/<name>(and the other spec-taking commands) said the deployment wasn't found right afterlsprinted it.Fix
list_deploymentsresolves thedeploymentGroupIdfilter first: an existing group id is used as is; otherwise the id of the one group with that name. More than one group with the name is a 400 asking for the id. A value that's neither still matches nothing, as before. A token scoped to a deployment group is unaffected (its own group is the filter).Tests
list_resolves_a_deployment_group_by_name:GET /v1/deployments?deploymentGroupId=local-dev&name=deployment-1lists with the group's generated id and returns the deployment.send).cargo test -p alien-managerpasses.🤖 Generated with Claude Code