Repository navigation
fix(examples): create the python-bindings sandbox without a tenant key (ALIEN-1215) - #849
Merged
ItamarZand88 merged 1 commit intoOct 4, 2026
Conversation
…y (ALIEN-1215) AWS, Azure and GCP refuse tenantKey, so the smoke workload failed on its first cloud run. It now creates a sandbox and terminates it when done.
|
Contributor
Author
|
@greptileai review Please review current head 9d5a700. The one finding on the previous review is answered in its thread: no code change, with the reason there. |
ItamarZand88
deleted the
itamar/alien-1215-python-bindings-example-passes-tenant-key
branch
October 4, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Python bindings smoke workload created its sandbox with
tenant_key, which AWS, Azure and GCP refuse. It now creates a plain sandbox and terminates it when done.Step-by-step flow when you run
python app.pyin the workload:sandbox("runtime").create()starts a sandbox. ← the fixpython -c "print('ready')"and checks the exit code.terminateruns infinally, so the sandbox is removed even if the check fails.This PR changes the example from
get_or_create(tenant_key=…)tocreate()plusterminate().What was broken
get_or_create(tenant_key="python-bindings-smoke")raisesOPERATION_NOT_SUPPORTEDon AWS (aws.rs:388), Azure (azure.rs:286) and GCP. The example only worked on Local and Kubernetes, which ignore the key.What I did
create(), and addedterminate()in afinallyblock so the sandbox doesn't outlive the run.Files touched
examples/python-bindings/app.pyHow I tested
maturin build --no-default-features --features local), thenruff checkandmypyon the example, as thepython-bindingsworkflow does: both clean.cargo test -p alien-bindings --lib unsupported_sandbox_fields_are_refused_not_droppedpasses, confirming AWS refusestenantKey.app.pyon a cloud. Every provider acceptscreate()with no arguments (read in each provider's create path); the rest of the smoke is unverified on a cloud.Safe because
create()with no arguments passes every provider's create-time checks. Unproven on a live cloud: a run ofapp.pyin an AWS workload would prove it.