Repository navigation
fix: preserve shared local image identity - #901
Merged
Merged
Conversation
|
Enclave skipped this draft pull request. It will run automatically when you mark the PR as Ready for review. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve actual immutable Docker image IDs before container creation and record them in resource/build labels. The lock map keeps weak entries and prunes completed imports under its map lock, while owners and waiters retain strong mutex references. Archive imports lock only shared content or affected references, with archive parsing outside the lock; unrelated images can load concurrently. Preserve registry content bytes through the updated image loader.
Validation: both real Docker integration tests passed twice. Each archive run starts with unique cold content, concurrently imports shared content, verifies both running containers and immutable identity, removes the owned containers/image, and checks the image is absent afterward. The registry test verifies container creation and labels use the inspected immutable ID. Image-loader library tests (38) and registry byte-preservation integration passed. Lock-retention regression passed, including a blocked shared waiter and 100 unrelated imports with bounded map size. Latest required CI is green on head 1ff668e. Combined CLI all-features build passed.
Combined CLI application validation passed all 11 conformance suites (113 checks), including native workers, uploads, nested projection, authentication and build tokens.