Repository navigation
fix(cli): a capability-only onboard link allows only what its package registers (ALIEN-1241) - #904
Merged
ItamarZand88 merged 1 commit intoOct 6, 2026
Conversation
… registers (ALIEN-1241) A link created with `alien onboard --setup-items <capability>` allowed every network, telemetry, updates and heartbeats mode. The built-in capability package registers no network, telemetry off, approval-required updates and heartbeats on, so the setup could request telemetry auto and could not complete. Without the application, onboard now allows only those modes.
|
ItamarZand88
deleted the
itamar/alien-1241-alien-onboard-setup-items-sandbox-creates-a-link-the-deploy
branch
October 6, 2026 09:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A link from
alien onboard --setup-items sandbox(or any capability without the application) could not be installed: the setup page asked for telemetryauto, and the capability package only acceptsoff. Without the application,onboardnow allows only the modes that package registers.Step-by-step flow when you run
alien onboard acme --setup-items sandbox:onboardcreates a deployment link with a policy of the stack settings the customer may pick.This PR changes a capability-only link from "every mode allowed" to "only the modes its package accepts".
What was broken
The link allowed telemetry
auto, so the setup page requested it and refused to launch: "This CloudFormation package supports telemetry mode 'off', but this setup requests 'auto'."What I did
platform_onboard_deployment_setup_configtakesincludes_application; without the application it allows networknone, telemetryoff, updatesapproval-required, heartbeatson.Files touched
crates/alien-cli/src/commands/onboard.rs: the policy for capability-only links, and a test for it.How I tested
a_capability_only_link_allows_the_settings_its_package_registersfailed before the fix (left: [Off, Auto, ApprovalRequired],right: [Off]) and passes now; all 20commands::onboardtests pass.auto.Safe because a link that includes the application gets the identical policy it got before: the
includes_applicationbranches keep the previous lists verbatim (see the diff). Not covered by a test.