Skip to content

fix: distinguish saved runtime failures during setup retry - #945

Merged
alongubkin merged 11 commits into
mainfrom
alon/alien-1325-saved-runtime-progress
Oct 8, 2026
Merged

alongubkin merged 11 commits into
mainfrom
alon/alien-1325-saved-runtime-progress

Conversation

@alongubkin

@alongubkin alongubkin commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

A setup retry painted retained runtime failures as though the new attempt had failed. After setup handed off to the manager, the CLI also stopped refreshing resource rows, leaving a red container failure beside a successful deployment.

Label retained Live failures as previous failures while setup runs. Keep the progress display active after handoff, refresh resource rows from each manager observation, and show the final activation outcome. Current runtime failures and setup-owned failures retain their diagnostics.

Validation: reproduced the stale final row in a real AWS recovery. The candidate repeat deliberately failed a container, added setup-owned storage with a healthy release, and recovered through normal deploy: previous-failure label during setup, final gateway Ready, activation Running, exit zero. Existing handoff tests and resource-row classification tests passed on the prior head.

Updated onto main after #940 merged, preserving its structured HTTP acquisition recovery, completion regressions, and progress callback cleanup. Changed-file Rust formatting passes. Fresh CI and Greptile are running on the resolved merge.

Linear: ALIEN-1325.

@enclave-ai

enclave-ai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Enclave skipped this draft pull request. It will run automatically when you mark the PR as Ready for review.

@alongubkin
alongubkin force-pushed the alon/alien-1325-saved-runtime-progress branch from a673fa9 to 785a485 Compare October 8, 2026 15:33
Base automatically changed from alon/alien-1317-install-resume to main October 8, 2026 16:14
@alongubkin
alongubkin marked this pull request as ready for review October 8, 2026 16:33
@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Medium risk] Changes deployment progress tracking and status display logic.

The PR appears safe to merge; the previous message-display issue is fixed.

What we checked:

  • Handoff notices stay visible: With live progress, messages are printed above the rows before those rows are redrawn. Without live progress, they still print to stdout.

Summary

The CLI labels saved runtime failures as previous failures during setup. It keeps resource rows fresh while waiting for the manager and shows the final activation result.

  • Handoff and blocked messages now stay above the live progress rows.
  • The previous finding is fixed. No new actionable issues were found.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Setup retry] --> B[Label saved runtime failures]
  B --> C[Hand off to manager]
  C --> D[Refresh resource rows]
  D --> E{Manager outcome}
  E -->|Running| F[Complete activation row]
  E -->|Failed or timed out| G[Fail activation row]
  E -->|Waiting| H[Print blocked message above live rows]
  H --> D
Loading

Reviews (2) · Last reviewed commit: "fix: preserve handoff messages during pr..." · Reviewed by Greptile

Comment thread crates/alien-cli/src/commands/deploy.rs
@alongubkin
alongubkin merged commit f47dc4e into main Oct 8, 2026
24 checks passed
@alongubkin
alongubkin deleted the alon/alien-1325-saved-runtime-progress branch October 8, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant