Skip to content

fix: sync hosted acquisition and operations SDK contracts - #951

Merged
alongubkin merged 4 commits into
mainfrom
alon/alien-948-hosted-acquisition-sdk
Oct 8, 2026
Merged

alongubkin merged 4 commits into
mainfrom
alon/alien-948-hosted-acquisition-sdk

Conversation

@alongubkin

@alongubkin alongubkin commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Sync the generated hosted API SDK with the acquisition outcome contract introduced in #699. Explicit requests now expose notAcquired with bounded rejection reasons, while responses from older servers can omit the field.

This dedicated SDK sync also preserves the operations configuration added on main instead of regenerating against an older schema. All three Rust/TypeScript OpenAPI inputs come from the source API generation pipeline; TypeScript models were generated with the pinned Speakeasy 1.799.0 CLI. Unrelated documentation example rewrites were restored as complete files.

Validation: TypeScript SDK build passes with NODE_OPTIONS=--max-old-space-size=16384 pnpm -C client-sdks/platform/typescript build. The generated Rust response has a default-empty not_acquired collection for compatibility with older servers. All 36 hosted controller deployment-store regressions pass, including acquisition outcome propagation and older responses without notAcquired.

@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Critical risk] Updates the public API contract for client SDKs.

The reviewed changes appear safe to merge, with no actionable new defect established.

What we checked:

  • Operator reports omit settings: The Operator calls reported_operations_config, which removes settings before building the sync request.
  • Configuration types remain available: OperationsConfig and its nested types are exported from syncreconcilerequest.ts. models/index.ts exports that whole file.

Summary

Syncs the hosted SDK with acquisition outcomes and preserves the operations contract.

  • Adds optional notAcquired results and bounded rejection reasons.
  • Restores operationsConfig, bundle env, and access-request approvalChannels.
  • Keeps all three OpenAPI inputs identical and updates generated documentation.

No actionable new issue was established. No previous review threads were supplied; GitHub access was unavailable. Builds and tests were not rerun.

Reviews (3) · Last reviewed commit: "fix: preserve optional operations and ap..." · Reviewed by Greptile

@greptile-apps

This comment has been minimized.

@alongubkin
alongubkin merged commit 0a680b9 into main Oct 8, 2026
23 of 24 checks passed
@alongubkin
alongubkin deleted the alon/alien-948-hosted-acquisition-sdk branch October 8, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant