Skip to content

fix: preserve reconcile validation errors in SDK contracts - #952

Merged
alongubkin merged 1 commit into
mainfrom
alon/alien-948-reconcile-validation-sdk
Oct 8, 2026
Merged

alongubkin merged 1 commit into
mainfrom
alon/alien-948-reconcile-validation-sdk

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Sync reconcile can reject invalid configuration with HTTP 422. Regenerate the checked-in OpenAPI contracts and TypeScript client so this response decodes as APIError and retains its structured code, retryability, and HTTP status.

Validation: generated with Speakeasy CLI 1.799.0; the generated TypeScript build passed. A local HTTP endpoint returning 422 was exercised through the real SDK reconcile call and verified typed APIError decoding and metadata. Restored unrelated documentation churn as whole files.

@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[Critical risk] Updates public API contract for reconcile endpoint.

This PR appears safe to merge; no actionable issues were found.

What we checked:

  • Rust uses the updated contract: build.rs watches and reads openapi.json, then generates the client during the build. This change does not need a checked-in Rust source update.

Summary

Adds HTTP 422 to the reconcile error contract so the TypeScript SDK returns APIError instead of a generic error.

  • Updates all three checked-in Platform OpenAPI contracts.
  • Updates the TypeScript error matcher, error documentation, and generation records.
  • No actionable issues found. No builds or runtime tests were run during this review.

Reviews (1) · Last reviewed commit: "fix: preserve reconcile validation error..." · Reviewed by Greptile

@alongubkin
alongubkin merged commit 2801921 into main Oct 8, 2026
24 checks passed
@alongubkin
alongubkin deleted the alon/alien-948-reconcile-validation-sdk branch October 8, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant