Repository navigation
fix: make local builds and supervised shutdown reliable - #984
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent failures make local development unreliable during cold builds and supervised shutdown.
rustup target addconcurrently, racing over shared download files. Serialize the check/install within the process, recheck under the lock, and release it before compilation. Report a failed target-list command immediately.alien devsession handles Ctrl-C but exits abruptly on SIGTERM, bypassing manager shutdown. Register SIGTERM for the session and route it through the existing shutdown path. Keep the listener alive during cleanup.Reproduction
x86_64-unknown-linux-musl:alien build --platforms local --targets linux-x64. Concurrent installation can fail with a missing.partialfile.alien dev --status-file status.json --no-browser, wait for Ready, then send SIGTERM to the CLI PID. Before this fix it exits from signal 15 and leaves Ready status; afterward it exits successfully and shuts down the manager.Validation
SIGTERM received during a cold build is handled when startup reaches the watch phase; this change does not implement immediate build cancellation. The install lock coordinates resource builds within one CLI process, not separate CLI processes.
Refs ALIEN-1382, ALIEN-1387.