Repository navigation
Write Allure result files atomically - #924
Merged
Merged
Conversation
andrcuns
approved these changes
Sep 18, 2026
delatrie
force-pushed
the
atomic-write
branch
from
September 18, 2026 19:24
03d6221 to
315e376
Compare
lorenzhs
added a commit
to firebolt-db/firebolt-python-sdk
that referenced
this pull request
Oct 7, 2026
Allure 2.16.1 introduced atomic report writes: io.open writes the temporary file on the real filesystem, but pyfakefs intercepts os.replace and searches the fake filesystem. Exclude the actual Allure modules so both operations use the real filesystem. Upstream: allure-framework/allure-python#924 Validation: Python 3.9.25, Allure 2.16.2, pyfakefs 5.6.0; full unit suite with coverage and Allure enabled: 778 passed, 1 skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The PR implements atomic writes: Allure result files are first written with the
.tmpsuffix then get renamed to their final names withos.replace.