Repository navigation
added verbs for put, patch and delete - #45
Merged
Merged
Conversation
Contributor
|
I am ok with merging this now as long we agree to revisit this implementation |
Closed
elorest
added a commit
that referenced
this pull request
Aug 26, 2017
* fixed DockerFile and cleaned up flash in controller template * fixed ecr rendering and bumped * very happy with the progress even if it is 2AM. :( * provision and deploy work so well :) * added spinner so people won't think it's frozen
marksiemers
pushed a commit
to marksiemers/amber
that referenced
this pull request
Oct 28, 2017
…-model changes for new macros
marksiemers
pushed a commit
to marksiemers/amber
that referenced
this pull request
Oct 28, 2017
elorest
added a commit
that referenced
this pull request
Nov 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds verbs for put, patch and delete. Fairly small change that doesn't seem to break anything. Don't merge it yet but I wanted to post it so that you didn't waste time in the same direction tomorrow.
Why Should This Be In Core?
Routing all restful routes is useful for web frameworks.
Benefits
All verbs now work. Params are parsed before the route is looked up. Also the looked up node is saved and used since it was always added to the chain by default. This means we don't have to look up the same route twice per request.
Possible Drawbacks
Params have to always be parsed in order to route.
Applicable Issues
If you include params in your pipeline now it will cause an issue because it's being used by default.