Skip to content

Routing breaks when the scaffold/resource contains "end" in the name #172

Open

Description

@CarlosAndresRamirez

Hello team,
I just found out that, when you create a scaffold/resource/route that contains "end" in the name, then the parsing of the routing file will fail next time. Basically, it will assume it is the "end" of the routes :web do section.

REPRODUCING THE BUG
amber g scaffold gender name:string

After this, try adding any other scaffold, the action will fail with:
"syntax error in './config/routes.cr:138:14': unexpected token: DELIMITER_START"
When checking the routes.cr file it is broken at the resources line for "gender" like this:
resources "g
---new scaffold here---
enders", GenderController

Thanks,

Activity

  1. changed the title [-]Routing breaks when certain scaffold names are used[/-] [+]Routing breaks when the scaffold/resource contains "end" in the name[/+] on Mar 4, 2020
  2. drujensen commented on Mar 4, 2020

    @drujensen
    Member

    @CarlosAndresRamirez Wow. Thanks for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions