Repository navigation
docs(sdk): document max_steps framework default of 50 - #5759
Merged
Merged
Conversation
Signed-off-by: Aman Awasthi <amandeavor@gmail.com>
Contributor
|
Verdict: Approve The SDK guide said agents stop after 20 reasoning steps by default, and the ChatAgent spec said 10. The real default is 50. This PR corrects all four places, and each new value matches the code. Nothing blocks the merge. Real-world evidenceN/A: this PR changes docs only. No runnable surface changed, so the verdict rests on reading the diff against the source. 🔍 Technical detailsVerified against source
Issues found
Strengths
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #3533
The SDK guide documented max_steps default as 20 in three places, and ChatAgentConfig documented 10, whereas the framework uses DEFAULT_MAX_STEPS = 50 (resolved via default_max_steps(), overridable by GAIA_AGENT_MAX_STEPS).
Changes
Checklist