feat: setup basic event structure - #3
Conversation
justin-fiedler
left a comment
justin-fiedler
left a comment
There was a problem hiding this comment.
See comment about type hints.
| def add(self, plugin): | ||
| pass | ||
| self.timeline.add(plugin) | ||
| return self |
There was a problem hiding this comment.
are we returning self so that we can chain method calls?
There was a problem hiding this comment.
yes, for chaining calls.
There was a problem hiding this comment.
@qingzhuozhen we're not allowing call chaining in js, specially for browser to support tree shaking, and I'd probably do the same for node for consistency. Should we address this parity?
There was a problem hiding this comment.
I saw the kotlin version returned this too. The backend part probably should do the same.
There was a problem hiding this comment.
This is an interesting one. I believe for tree shaking support we could do something different in js. Some customers did ask about chaining support like in iOS (supported in android), wonder if we should allow un-parity on this.
| def add(self, plugin): | ||
| pass | ||
| self.timeline.add(plugin) | ||
| return self |
There was a problem hiding this comment.
This is an interesting one. I believe for tree shaking support we could do something different in js. Some customers did ask about chaining support like in iOS (supported in android), wonder if we should allow un-parity on this.
|
lgtm |
…er for visibility
4 participants
Summary
Checklist