Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes small formatting-only fixes in the Todo app files, adds a standalone Python merge sort implementation, and updates the repository README with an additional section.
Changes:
- Fix closing brace/tag formatting at EOF in
todo-appCSS/HTML/JS files. - Add
merge_sort.pywith a merge sort + merge implementation and a__main__demo. - Extend
README.mdwith a new “Poem for Coders” section.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| todo-app/styles.css | Minor formatting/EOF brace adjustment in responsive CSS block. |
| todo-app/index.html | Minor formatting/EOF closing </html> adjustment. |
| todo-app/app.js | Minor formatting/EOF closing brace adjustment in loadTodos(). |
| merge_sort.py | New Python merge sort implementation + demo/test prints under __main__. |
| README.md | Adds an extra documentation section (poem) above the Todo app docs. |
| """ | ||
| Merge Sort Algorithm Implementation | ||
|
|
||
| MEMORY: This file contains a simple merge sort implementation in Python. |
There was a problem hiding this comment.
The module docstring includes a "MEMORY:" line that looks like an internal note rather than user-facing documentation. Please remove it or replace it with a normal summary sentence so the docstring is consistent and not confusing to readers.
| MEMORY: This file contains a simple merge sort implementation in Python. | |
| This module contains a simple merge sort implementation in Python. |
| Returns: | ||
| list: A new sorted array | ||
| """ | ||
| # Base case: arrays with 1 or 0 elements are already sorted | ||
| if len(arr) <= 1: | ||
| return arr |
There was a problem hiding this comment.
The docstring says this returns "a new sorted array", but for inputs of length 0/1 the function returns the original list object (return arr). Either update the docstring to not promise a new list, or ensure the base case also returns a new list (e.g., a shallow copy) so the return semantics are consistent.
| def merge_sort(arr): | ||
| """ |
There was a problem hiding this comment.
The PR title/description don’t mention adding a new root-level merge_sort.py module (and README content updates). Please update the PR description to reflect the intent/scope of these changes so reviewers and release notes are accurate.
This is the second pull request review