Skip to content

Exptest7 - #72

Open
andrewyk wants to merge 3 commits into
mainfrom
exptest7
Open

andrewyk wants to merge 3 commits into
mainfrom
exptest7

Conversation

@andrewyk

Copy link
Copy Markdown
Owner

This is the second pull request review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes small formatting-only fixes in the Todo app files, adds a standalone Python merge sort implementation, and updates the repository README with an additional section.

Changes:

  • Fix closing brace/tag formatting at EOF in todo-app CSS/HTML/JS files.
  • Add merge_sort.py with a merge sort + merge implementation and a __main__ demo.
  • Extend README.md with a new “Poem for Coders” section.

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
todo-app/styles.css Minor formatting/EOF brace adjustment in responsive CSS block.
todo-app/index.html Minor formatting/EOF closing </html> adjustment.
todo-app/app.js Minor formatting/EOF closing brace adjustment in loadTodos().
merge_sort.py New Python merge sort implementation + demo/test prints under __main__.
README.md Adds an extra documentation section (poem) above the Todo app docs.

Comment thread merge_sort.py
"""
Merge Sort Algorithm Implementation

MEMORY: This file contains a simple merge sort implementation in Python.

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module docstring includes a "MEMORY:" line that looks like an internal note rather than user-facing documentation. Please remove it or replace it with a normal summary sentence so the docstring is consistent and not confusing to readers.

Suggested change
MEMORY: This file contains a simple merge sort implementation in Python.
This module contains a simple merge sort implementation in Python.

Copilot uses AI. Check for mistakes.
Comment thread merge_sort.py
Comment on lines +18 to +23
Returns:
list: A new sorted array
"""
# Base case: arrays with 1 or 0 elements are already sorted
if len(arr) <= 1:
return arr

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring says this returns "a new sorted array", but for inputs of length 0/1 the function returns the original list object (return arr). Either update the docstring to not promise a new list, or ensure the base case also returns a new list (e.g., a shallow copy) so the return semantics are consistent.

Copilot uses AI. Check for mistakes.
Comment thread merge_sort.py
Comment on lines +11 to +12
def merge_sort(arr):
"""

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title/description don’t mention adding a new root-level merge_sort.py module (and README content updates). Please update the PR description to reflect the intent/scope of these changes so reviewers and release notes are accurate.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants