fix(tui): support copying over ssh with set-clipboard on tmux config

[ayubun]

Issue for this PR

Closes #25253
Closes #25252
Closes #19982
Closes #15907
Maybe Closes #36646
(possibly more?)

Type of change

• Bug fix
• New feature
• Refactor / code improvement
• Documentation

What does this PR do?

the appropriate config for clipboard management in modern tmux versions is set-clipboard: https://github.com/tmux/tmux/wiki/Clipboard

this PR makes it so that the copy to clipboard feature sends raw OSC52 when inside tmux, because that is what the set-clipboard feature is expecting (see tmux maintainer commentary: tmux/tmux#4214 (comment))

because opencode currently sends the \x1bPtmux;\x1b escape sequence when it recognizes the TMUX env, the set-clipboard feature does not function as-intended, forcing people to use allow-passthrough (which has its own security implications)

How did you verify your code works?

i built the darwin and x86 binaries, and tested locally + on my remote by sending a prompt and then using the copy feature to copy the text. then, i pasted elsewhere to validate

• in all cases, testing outside of tmux works as expected, both in the old and new binary
• with a default tmux config, local works & remote fails for both the old and new binary (expected, unfortunately)
• with a set-clipboard on tmux config:
  • local works before & after
  • remote fails before & works after (this is the primary fix for this PR)
• with a allow-passthrough on tmux config:
  • local works before & after
  • remote works before, but not after (unless set-clipboard on)

Screenshots / recordings

N/A

Checklist

• I have tested my changes locally
• I have not included unrelated changes in this PR

[github-actions]

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found two related PRs that are worth reviewing:

1. PR fix(cli): handle OSC52 clipboard passthrough properly under GNU screen #28592: fix(cli): handle OSC52 clipboard passthrough properly under GNU screen

   • fix(cli): handle OSC52 clipboard passthrough properly under GNU screen #28592
   • This addresses similar clipboard passthrough issues in a different terminal multiplexer (GNU screen)

2. PR fix(clipboard): write OSC52 to /dev/tty instead of stdout #12129: fix(clipboard): write OSC52 to /dev/tty instead of stdout

   • fix(clipboard): write OSC52 to /dev/tty instead of stdout #12129
   • This is an earlier fix to the clipboard/OSC52 handling system

These PRs are related in that they all address OSC52 clipboard functionality, though they target different scenarios (tmux vs screen, and different output approaches). PR #30472 (the current PR) is specifically focused on fixing tmux's set-clipboard on mode with raw OSC52 sequences, which is a more targeted fix than the earlier PRs.

[github-actions]

Thanks for updating your PR! It now meets our contributing guidelines. 👍

[simonklee]

While simple this pr sends multiple of the sequence. I explored a fix for this a long time ago anomalyco/opentui#1215 which i still need ot get back to.

[ayubun]

While simple this pr sends multiple of the sequence. I explored a fix for this a long time ago anomalyco/opentui#1215 which i still need ot get back to.

in what case would a user be using tmux passthrough but not set-clipboard on ? tmux set-clipboard on has been the standard for a while now, and it works even if you have passthrough enabled.. i dont see why we cant just send the regular OSC52 sequence in all cases. having an env (the PR you linked as WIP) feels pretty overengineered imo

i'm fine not double-sending the sequence; i only proposed that so it would be easier to accept the PR on the grounds of backwards compatibility. i've modified it to only send one, so now it's a one-liner

@simonklee

[simonklee]

While simple this pr sends multiple of the sequence. I explored a fix for this a long time ago anomalyco/opentui#1215 which i still need ot get back to.

in what case would a user be using tmux passthrough but not set-clipboard on ? tmux set-clipboard on has been the standard for a while now, and it works even if you have passthrough enabled.. i dont see why we cant just send the regular OSC52 sequence in all cases. having an env (the PR you linked as WIP) feels pretty overengineered imo

i'm fine not double-sending the sequence; i only proposed that so it would be easier to accept the PR on the grounds of backwards compatibility. i've already modified it, now it's quite literally a one-liner

@simonklee

Yeah, i buy that.

[ayubun]

While simple this pr sends multiple of the sequence. I explored a fix for this a long time ago anomalyco/opentui#1215 which i still need ot get back to.

in what case would a user be using tmux passthrough but not set-clipboard on ? tmux set-clipboard on has been the standard for a while now, and it works even if you have passthrough enabled.. i dont see why we cant just send the regular OSC52 sequence in all cases. having an env (the PR you linked as WIP) feels pretty overengineered imo
i'm fine not double-sending the sequence; i only proposed that so it would be easier to accept the PR on the grounds of backwards compatibility. i've already modified it, now it's quite literally a one-liner
@simonklee

Yeah, i buy that.

is that sarcasm .. ? i genuinely cant tell o.o

it really was my intention, as i even mentioned it in the PR description long before you reviewed

[simonklee]

While simple this pr sends multiple of the sequence. I explored a fix for this a long time ago anomalyco/opentui#1215 which i still need ot get back to.

in what case would a user be using tmux passthrough but not set-clipboard on ? tmux set-clipboard on has been the standard for a while now, and it works even if you have passthrough enabled.. i dont see why we cant just send the regular OSC52 sequence in all cases. having an env (the PR you linked as WIP) feels pretty overengineered imo
i'm fine not double-sending the sequence; i only proposed that so it would be easier to accept the PR on the grounds of backwards compatibility. i've already modified it, now it's quite literally a one-liner
@simonklee

Yeah, i buy that.

is that sarcasm .. ? i genuinely cant tell o.o

it really was my intention, as i even mentioned it in the PR description long before you reviewed

No, i meant i think your argument is sound and that this looks good.

[ayubun]

While simple this pr sends multiple of the sequence. I explored a fix for this a long time ago anomalyco/opentui#1215 which i still need ot get back to.

in what case would a user be using tmux passthrough but not set-clipboard on ? tmux set-clipboard on has been the standard for a while now, and it works even if you have passthrough enabled.. i dont see why we cant just send the regular OSC52 sequence in all cases. having an env (the PR you linked as WIP) feels pretty overengineered imo
i'm fine not double-sending the sequence; i only proposed that so it would be easier to accept the PR on the grounds of backwards compatibility. i've already modified it, now it's quite literally a one-liner
@simonklee

Yeah, i buy that.

is that sarcasm .. ? i genuinely cant tell o.o
it really was my intention, as i even mentioned it in the PR description long before you reviewed

No, i meant i think your argument is sound and that this looks good.

oh i see, sorry it's difficult to read the intentions on text; thank you for your time

[simonklee]

changed my mind and went back to y our original impl.

[simonklee]

I'll test this and merge tomorrow.