fix(ui): line number click and hover utility not opening comment editor - #33480
Closed
sshwy wants to merge 1 commit into
Closed
fix(ui): line number click and hover utility not opening comment editor#33480sshwy wants to merge 1 commit into
sshwy wants to merge 1 commit into
Conversation
- selection-bridge: allow single-line number column clicks to trigger onLineNumberSelectionEnd, not just multi-line drags - file.tsx: route number column clicks through selection flow instead of returning early, and add enableGutterUtility/renderGutterUtility to SharedProps matching pierre's native option names - session-review / file-tabs: rename enableHoverUtility → enableGutterUtility and renderHoverUtility → renderGutterUtility
github-actions
Bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: The search results only return the current PR itself (33480), which is expected. The other result found (PR #19135) is unrelated to this issue—it's about TUI prompt navigation, not UI comment editor functionality. No duplicate PRs found |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #32835
Type of change
What does this PR do?
Two fixes for the review panel comment feature:
Clicking a line number now opens the comment editor. Previously
handleMouseUpreturned early for number column clicks, skipping all selection callbacks.
Fix: route number column clicks through the same selection flow as text clicks,
and relax
consume()to accept single-line selections from the gutter.The hover "+" button now renders. The props were named
enableHoverUtility/renderHoverUtilitybut pierre expectsenableGutterUtility/renderGutterUtility.Fix: rename props to match pierre's option names and add them to
SharedProps.How did you verify your code works?
bun dev serveand web app withbun run --cwd packages/app devScreenshots / recordings
screenshot.mov
Checklist
If you do not follow this template your PR will be automatically rejected.