Skip to content

fix(tui): prevent model/agent reset on Prompt remount - #34217

Closed
dsy122 wants to merge 1 commit into
anomalyco:devfrom
dsy122:fix/tui-model-reset-on-question
Closed

fix(tui): prevent model/agent reset on Prompt remount#34217
dsy122 wants to merge 1 commit into
anomalyco:devfrom
dsy122:fix/tui-model-reset-on-question

Conversation

@dsy122

@dsy122 dsy122 commented Jun 27, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #34207

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Moving syncedSessionID from component closure to module level. This variable guards against re-syncing model/agent from lastUserMessage() on Prompt remount — when a question or permission dialog appears, the Prompt unmounts and remounts, which previously reset the guard and triggered an unwanted sync, overwriting any manual model selection.

How did you verify your code works?

  1. Open session and trigger the agent to trigger question
  2. While the agent is still running, switch model from A to B
  3. Question appears, and after answering, the model stays B

Screenshots / recordings

2026-06-27.19-54-33.mp4

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@dsy122
dsy122 marked this pull request as ready for review June 27, 2026 12:07
@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model selection silently reverts after answering a question

1 participant