fix(ui): preserve code spans adjacent to tildes - #35835
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens markdown rendering in packages/ui by adding a Marked extension that prevents adjacent tilde/backtick runs from being coalesced, preserving inline code spans in edge cases, while also updating Marked to a newer patch release.
Changes:
- Add a
MarkedExtensiontokenizer workaround (markedCodeSpanBoundary) to keep~runs and backtick runs separate at inline boundaries. - Wire the workaround into the existing
MarkedProviderextension pipeline inpackages/ui. - Add focused regression tests and bump
markedfrom17.0.1to17.0.6(plus lockfile update).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ui/src/context/marked.tsx | Composes the new code-span boundary workaround into the UI Marked configuration pipeline. |
| packages/ui/src/context/marked-code-span.ts | Introduces the Marked tokenizer workaround for adjacent tilde/backtick boundaries. |
| packages/ui/src/context/marked-code-span.test.ts | Adds regression coverage for the inline-code/tilde adjacency cases (including strikethrough interaction). |
| package.json | Updates the repo’s marked dependency to 17.0.6. |
| bun.lock | Locks the dependency update for marked@17.0.6. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,17 @@ | |||
| import type { MarkedExtension } from "marked" | |||
|
|
|||
| // Keep adjacent tilde and backtick runs separate until markedjs/marked#4011 is released. | |||
jerome-benoit
pushed a commit
to jerome-benoit/opencode
that referenced
this pull request
Jul 14, 2026
avion23
pushed a commit
to avion23/opencode
that referenced
this pull request
Jul 17, 2026
avion23
pushed a commit
to avion23/opencode
that referenced
this pull request
Jul 20, 2026
3kaiu
pushed a commit
to 3kaiu/opencode-x
that referenced
this pull request
Jul 31, 2026
MarsQiu007
pushed a commit
to MarsQiu007/openNovel
that referenced
this pull request
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes
Summary
Upstream issue: markedjs/marked#4011
Upstream fix: markedjs/marked#4012
Testing
bun test src --only-failuresinpackages/uibun test src --only-failuresinpackages/session-uibun install --frozen-lockfilebun turbo typecheck