fix(app): clarify status indicator severity - #36031
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the app’s status indicator severity so the dot stays green when the server is healthy, uses the existing warning token for non-blocking MCP/LSP issues, and reserves the critical token for an offline server—consistently across both popover variants.
Changes:
- Centralized status-dot classification logic into a shared helper (
serverStatusDotClass) used by both popover triggers. - Reframed MCP/LSP problems as non-blocking “warning” for the indicator while keeping server-offline as “critical”.
- Added targeted unit tests covering the new indicator classification behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/app/src/components/status-popover.tsx | Uses shared indicator helpers and aligns trigger-dot severity rules across popover variants. |
| packages/app/src/components/status-popover-indicator.ts | Introduces shared helper functions to detect non-blocking service issues and compute the dot’s severity class. |
| packages/app/src/components/status-popover-indicator.test.ts | Adds unit tests validating the new indicator class selection and issue detection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+4
| type McpStatus = "connected" | "disabled" | "failed" | "needs_auth" | "needs_client_registration" | ||
| type LspStatus = "connected" | "error" | ||
|
|
||
| export function hasNonBlockingServiceIssue(input: { mcp: McpStatus[]; lsp: LspStatus[] }) { |
jerome-benoit
pushed a commit
to jerome-benoit/opencode
that referenced
this pull request
Jul 14, 2026
avion23
pushed a commit
to avion23/opencode
that referenced
this pull request
Jul 17, 2026
avion23
pushed a commit
to avion23/opencode
that referenced
this pull request
Jul 20, 2026
3kaiu
pushed a commit
to 3kaiu/opencode-x
that referenced
this pull request
Jul 31, 2026
MarsQiu007
pushed a commit
to MarsQiu007/openNovel
that referenced
this pull request
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bg-icon-warning-basetoken for non-blocking MCP and LSP issues.Testing
bun test ./src/components/status-popover-indicator.test.tsbun typecheckbunx prettier --check src/components/status-popover.tsx src/components/status-popover-indicator.ts src/components/status-popover-indicator.test.ts