Skip to content

Http2 stream retry - #41390

Closed
zopenb wants to merge 5 commits into
anomalyco:devfrom
zopenb:http2-stream-retry
Closed

Http2 stream retry#41390
zopenb wants to merge 5 commits into
anomalyco:devfrom
zopenb:http2-stream-retry

Conversation

@zopenb

@zopenb zopenb commented Aug 9, 2026

Copy link
Copy Markdown

Issue for this PR

Closes #

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR.

If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!

How did you verify your code works?

Screenshots / recordings

If this is a UI change, please include a screenshot or recording.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Hey! Your PR title Http2 stream retry doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • No "Type of change" checkbox is checked. Please select at least one.
  • No issue referenced. Please add Closes #<number> linking to the relevant issue.
  • "How did you verify your code works?" section is empty. Please explain how you tested.
  • Not all checklist items are checked. Please confirm you have tested locally and have not included unrelated changes.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on the search results, I found several related PRs that address stream retry and recovery logic:

Potential Related PRs:

  1. fix: retry truncated provider streams #39473 - fix: retry truncated provider streams - Directly addresses provider stream retry logic
  2. fix(session): retry top-level stream request timeouts #40268 - fix(session): retry top-level stream request timeouts - Handles stream request timeout retries
  3. fix(provider): recover stalled model streams #40010 - fix(provider): recover stalled model streams - Addresses stalled stream recovery
  4. fix(session): retry HTTP 408 request timeouts #39413 - fix(session): retry HTTP 408 request timeouts - HTTP timeout retry handling
  5. fix(opencode): apply default header timeout to all providers #40069 - fix(opencode): apply default header timeout to all providers - Related timeout handling
  6. fix(opencode): make long-lived provider streams robust to silent SSE terminations #39970 - fix(opencode): make long-lived provider streams robust to silent SSE terminations - Stream robustness improvements

These PRs all address related concerns around stream handling, retry logic, and timeout management. PR #41390 (the current PR) should be reviewed against these to ensure there's no duplicate effort or conflicting approaches to HTTP/2 stream retry functionality.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Aug 9, 2026
@github-actions github-actions Bot closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant