fix(app): fallback blob ID generation for non-secure HTTP contexts - #41710
Open
jibin7jose wants to merge 1 commit into
Open
fix(app): fallback blob ID generation for non-secure HTTP contexts#41710jibin7jose wants to merge 1 commit into
jibin7jose wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41706
Type of change
What does this PR do?
Fixes an issue where pasting an image in a non-secure HTTP context (e.g. over a remote server IP) causes a crash. The
blobIDfunction was usingcrypto.subtle.digest, but the Web Crypto API spec makescrypto.subtleundefined in non-secure contexts.This PR updates
blobIDto check ifglobalThis.crypto?.subtleis available. If it's not, it falls back to a non-cryptographic random string for the ID, allowing images to paste normally.How did you verify your code works?
Verified that the
globalThis.crypto?.subtlecheck successfully prevents theTypeErrorand falls back correctly when accessed over plain HTTP.Screenshots / recordings
Checklist