Repository navigation
fix(core): exempt live-child locations from idle eviction - #51827
Open
KamitobiHaru wants to merge 1 commit into
Open
KamitobiHaru wants to merge 1 commit into
KamitobiHaru wants to merge 1 commit into
Conversation
LocationActivity tore down location-scoped Shell/Pty services after 60 minutes without session events, SIGTERMing background children while the service stayed alive. Add LocationRetention registry. Shell and Pty retain on create, release on settle/remove/teardown. The sweep touches pinned locations instead of invalidating them. Explicit invalidate still tears down immediately. No task persistence.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #51828
Type of change
What does this PR do?
A background shell running a long job gets SIGTERM'd when
LocationActivityevicts its location after 60 minutes without session events. The service
process itself stays alive (same PID throughout); only the location-scoped
Shell/Pty graph is torn down, because
locations.invalidate()closes thescope-bound child-process handles.
Seen on 2026-09-27 (service 2.0.10):
location services evicted directory=/data3/zsy/asr2report_pipelineat 16:24:48.527Z, torchrunReceived 15 death signalat 16:24:48.563Z, payload's own handler wroterc=143, signal=15. No service restart near the window, so this is theinactivity sweeper, not the
ensure()replacement path.Why it happens: the sweep only exempts locations that own active
SessionExecutionsessions. A backgrounded shell/pty emits no sessionevents and holds no execution claim, so its location looks idle and gets
invalidated out from under the live child.
Changes:
LocationRetentionregistry (packages/core/src/location-retention.ts,global node) tracking locations with live child processes, keyed by the
same identity the sweep uses (
LocationServiceMap.canonical+workspaceID via a shared
keyOf, so pins can't silently miss).shell.ts/pty.ts: retain on create, release on settle/remove/teardown(per-command
retainedflag, no double-release). Teardown still killsrunning children and now logs them.
location-activity.ts: expired entries with live children are touched(deadline deferred, no reference taken) and skipped; rest unchanged.
Explicit
invalidatestill tears down immediately (registry is only readin the sweep). No task persistence.
How did you verify your code works?
bun typecheckclean inpackages/core.location-retention.test.ts(5 unit) andlocation-activity-retention.test.ts(2 TestClock sweep tests: a pinnedlocation survives past TTL and evicts after release; explicit invalidate
still tears down a pinned location without leaking the pin).
pty-session(7),location-activity(4),browser-idle(1, only needed the new node dep),session-shell/tool-shell/shell-retention(97 pass, 19 platform skips).background shell (
POST /api/shell,sleep 4000, DEBUG, isolatedXDG_DATA_HOME): pinned 08:48:43Z,eviction deferred09:49:22Z (firstsweep after the 09:48:43Z deadline; the touch pushes the deadline an hour
out so a single line is the whole story),
running+ process-alive pollsat 09:48:58Z and 09:53:58Z, natural
exit=0withunpinned, idle eviction resumedat 09:55:23Z. Zerolocation services evicted, zero SIGTERM.Full logs attached:
v2-server-monitor.log,v2-server-serve.log,v2-server-opencode.log,v2-local-verify.log.Screenshots / recordings
N/A (no UI change).
Checklist