Repository navigation
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
This was referenced Nov 13, 2026
Author
|
I have read the CLA Document and I hereby sign the CLA. |
Build capability metadata once in buffa-codegen and use it for success and error responses from both plugin binaries. Preserve the existing feature flags and supported edition range, and test each executable error response.
vanderbr
force-pushed
the
plugin-error-editions
branch
from
November 17, 2026 13:42
9935bd9 to
a62d2b4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
protoc-gen-buffaandprotoc-gen-buffa-packagingcan return an error response advertising editions support without its required minimum and maximum edition fields. Buf rejects that response before displaying the plugin's own diagnostic. For example, an invalid packagingfilterproduces a missing-edition protocol error instead of the useful configuration error, even for proto3 input.Add
buffa_codegen::plugin_response_metadata()and use it for all four success/error response construction sites across the two plugins. It advertises proto3 optional support and the existingEDITION_PROTO2throughEDITION_2024range. This centralizes the metadata without changing successful generation.Validation:
The MSRV remains Rust 1.75 and the development toolchain remains 1.95.0. Dependency manifests and lockfiles are unchanged. Changelog entries cover the packaging fix and the new shared API.
Contributed by ReallyMe Technologies Limited.