Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changes/unreleased/fixed-20261117-enum-128-bit-integers.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: Fixed
body: 'Enum deserialization through serde formats that deliver 128-bit integers, including JSON Value deserialization with serde_json/arbitrary_precision enabled, no longer echoes the number in errors. A number beyond the 64-bit range reports that it is out of range, and an in-range number takes the same path as a 64-bit one instead of being rejected as an invalid type. This covers generated enum values, enum fields, and reflective enum values.'
time: 2026-11-17T12:00:00Z
3 changes: 3 additions & 0 deletions .changes/unreleased/security-20261114-002418.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
kind: Security
body: 'Enum JSON value errors omit the input name or number. This covers generated enum values, enum field values and elements, registered enum extensions, and reflective enum values. Malformed scalar input at enum list and map boundaries is also omitted; the shared reflective collection visitors apply the same rule to other list and map fields. Accepted JSON values and lenient parsing behavior are unchanged. Regenerate existing bindings with the matching generator to update standalone enum deserialization.'
time: 2026-11-14T00:24:18Z
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ jobs:
- name: Tests
run: cargo test --workspace

# Feature unification can deliver wide JSON numbers through 128-bit
# visitor callbacks when decoding a Value instead of JSON text.
- name: Enum diagnostics with arbitrary precision
run: cargo test -p buffa-test --features serde_json/arbitrary_precision --test enum_json_precision -- --ignored

# Optional features must keep compiling — #88 was a feature-flag-only
# break that escaped the default-features test pass above. cargo check
# is sufficient to catch compile breaks without doubling the test time.
Expand Down
49 changes: 1 addition & 48 deletions buffa-codegen/src/enumeration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,54 +26,7 @@ fn generate_enum_serde(name_ident: &Ident) -> TokenStream {

impl<'de> ::serde::Deserialize<'de> for #name_ident {
fn deserialize<__D: ::serde::Deserializer<'de>>(d: __D) -> ::core::result::Result<Self, __D::Error> {
struct _V;
impl ::serde::de::Visitor<'_> for _V {
type Value = #name_ident;

fn expecting(&self, f: &mut ::core::fmt::Formatter<'_>) -> ::core::fmt::Result {
f.write_str(concat!("a string, integer, or null for ", stringify!(#name_ident)))
}

fn visit_str<__E: ::serde::de::Error>(self, v: &str) -> ::core::result::Result<#name_ident, __E> {
<#name_ident as ::buffa::Enumeration>::from_proto_name(v).ok_or_else(|| {
::serde::de::Error::invalid_value(
::serde::de::Unexpected::Str(v),
&"a known enum variant name",
)
})
}

fn visit_i64<__E: ::serde::de::Error>(self, v: i64) -> ::core::result::Result<#name_ident, __E> {
let v32 = i32::try_from(v).map_err(|_| {
::serde::de::Error::custom(
::buffa::alloc::format!("enum value {v} out of i32 range")
)
})?;
<#name_ident as ::buffa::Enumeration>::from_i32(v32).ok_or_else(|| {
::serde::de::Error::custom(
::buffa::alloc::format!("unknown enum value {v32}")
)
})
}

fn visit_u64<__E: ::serde::de::Error>(self, v: u64) -> ::core::result::Result<#name_ident, __E> {
let v32 = i32::try_from(v).map_err(|_| {
::serde::de::Error::custom(
::buffa::alloc::format!("enum value {v} out of i32 range")
)
})?;
<#name_ident as ::buffa::Enumeration>::from_i32(v32).ok_or_else(|| {
::serde::de::Error::custom(
::buffa::alloc::format!("unknown enum value {v32}")
)
})
}

fn visit_unit<__E: ::serde::de::Error>(self) -> ::core::result::Result<#name_ident, __E> {
::core::result::Result::Ok(::core::default::Default::default())
}
}
d.deserialize_any(_V)
::buffa::json_helpers::closed_enum::deserialize_strict(d)
}
}

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading