Skip to content

types: enable std for generated arbitrary support - #837

Open
vanderbr wants to merge 2 commits into
anthropics:mainfrom
reallyme:maintenance/feature-wiring
Open

vanderbr wants to merge 2 commits into
anthropics:mainfrom
reallyme:maintenance/feature-wiring

Conversation

@vanderbr

Copy link
Copy Markdown

buffa-types and buffa-descriptor fail to compile for an isolated consumer using --no-default-features --features arbitrary: generated derives reference std, and the allocation-only map representation does not implement Arbitrary. Workspace feature unification can hide both errors.

Make arbitrary enable each crate's std feature, which also selects the runtime's compatible map representation. Document the requirement and add isolated checks for arbitrary and arbitrary,json across buffa-types, buffa-descriptor, and buffa-proto-options on the host and wasm32-unknown-unknown. The helper enters the repository directory so it uses the pinned toolchain and configuration when CI invokes it from elsewhere. Bare-metal ARM checks preserve coverage for ordinary builds without std.

This applies directly to upstream main and has no dependency on another PR. Package versions, the Rust 1.75 MSRV, and the development toolchain pin are unchanged. No code-generation output changes.

Validation:

  • Confirmed the isolated buffa-types build fails before the fix and passes afterward.
  • Passed the full workspace test suite with all features, formatting checks, strict all-target/all-feature Clippy, and strict documentation checks for the affected crates.
  • Passed the isolated host/Wasm feature matrix and ordinary no-default-feature ARM builds.
  • Passed a Rust 1.75 consumer build, workflow validation, and Markdown lint.

@github-actions

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant