Repository navigation
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buffa-typesandbuffa-descriptorfail to compile for an isolated consumer using--no-default-features --features arbitrary: generated derives referencestd, and the allocation-only map representation does not implementArbitrary. Workspace feature unification can hide both errors.Make
arbitraryenable each crate'sstdfeature, which also selects the runtime's compatible map representation. Document the requirement and add isolated checks forarbitraryandarbitrary,jsonacrossbuffa-types,buffa-descriptor, andbuffa-proto-optionson the host andwasm32-unknown-unknown. The helper enters the repository directory so it uses the pinned toolchain and configuration when CI invokes it from elsewhere. Bare-metal ARM checks preserve coverage for ordinary builds withoutstd.This applies directly to upstream
mainand has no dependency on another PR. Package versions, the Rust 1.75 MSRV, and the development toolchain pin are unchanged. No code-generation output changes.Validation:
buffa-typesbuild fails before the fix and passes afterward.