Repository navigation
chore: remove orphaned dead code from v1.0 entrypoint consolidation - #1727
Open
Abdullah-Builds wants to merge 1 commit into
Open
Abdullah-Builds wants to merge 1 commit into
Abdullah-Builds wants to merge 1 commit into
Conversation
Contributor
Author
|
@chrislloyd waiting for approval |
Contributor
Author
|
@dougbarth waiting for approval |
Contributor
Author
|
@chrislloyd I am following up on this PR Please let me know if anything to do further |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1668.
What this does
Removes the three confirmed-dead pieces of code from the v1.0
run.tsconsolidation:src/entrypoints/prepare.ts(103 lines) — orphaned duplicate of the prepare phase.action.ymlonly ever invokesrun.ts,cleanup-ssh-signing.ts, andpost-buffered-inline-comments.ts; nothing imports this file.updateTrackingComment(src/github/operations/comments/update-with-branch.ts) — the file's only export, no callers. Superseded byupdateCommentLinkviacheckAndCommitOrDeleteBranch.checkTriggerAction(src/github/validation/trigger.ts) — thin wrapper aroundcheckContainsTriggerthat also set acontains_triggeroutput nobody declares inaction.yml. Removed the now-unused@actions/coreimport along with it;ParsedGitHubContextstays, sincecheckContainsTriggerstill needs it.On the confirmation question in the issue
The issue asks for confirmation that
prepare.tsis genuinely dead before opening a PR. I re-ran the same checks independently against currentmain:Same for
updateTrackingCommentandcheckTriggerAction— each symbol's only match is its own definition. I also confirmedaction.ymlnever declares acontains_triggeroutput, and checkedtest/prepare-context.test.tsisn't related (it testsprepareContextfromsrc/create-prompt, unconnected to the deletedprepare.tsentrypoint — naming coincidence).Item 4 — left untouched
Per the issue, the
ALLOWED_TOOLS/DISALLOWED_TOOLSdead env var exports insrc/create-prompt/index.tsare intentionally not touched here. The existing code comment says they're kept so an H1 report's referenced file stays in sync with the live fix — that's a maintainer call, not mine.Testing
I don't have a working
buntoolchain in the environment I used to prepare this, so I wasn't able to runbun test/bun run typecheck/bun run format:checkmyself. The change is a pure deletion (no logic touched in surviving code besides the one import), but please treat CI as the real verification here rather than my word for it.