riscv: canonicalize malformed half operands for fclass.h - #36
Open
carlosqwqqwq wants to merge 1 commit into
Open
riscv: canonicalize malformed half operands for fclass.h#36carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary On RV64, a non-NaN-boxed half value is a canonical quiet NaN. The
fclass.htranslation path currently passes the raw FPR value to the classification helper, unlike the other half-precision paths. Unbox the operand before classification. ## Validation - The malformed-operand witness returns the quiet-NaN class bit after the fix; the boxed control is unchanged. - Renode, QEMU and native RISC-V hardware controls agree. - The patch is limited to thefclass.htranslation branch. Fixes renode/renode#958 ## Public reproduction and integration The corresponding public Robot reproduction is available at https://github.com/carlosqwqqwq/renode-issue-reproduction-template/tree/main. The focused change is also included in the combined integration branch in tlib #44, followed by renode-infrastructure #245 and Renode #989.