Allow defining ttlSecondsAfterFinished in databaseCleanup cleanup job through helm chart installation

[fbmatilla]

Description

We want to be able to define the ttlSecondsAfterFinished value in the values.yml when deployin Airflow Helm Chart. This is already permitted in createUserJob and migrateDatabaseJob.

Use case/motivation

In the file airflow/chart/templates/database-cleanup
/database-cleanup-cronjob.yaml

a new piece of code like:

spec:
.....
jobTemplate:
spec:
{{- if not (kindIs "invalid" .Values.databaseCleanup.ttlSecondsAfterFinished) }}
ttlSecondsAfterFinished: {{ .Values.databaseCleanup.ttlSecondsAfterFinished }}
{{- end }}
template:
....

Related issues

New feature, not really an issue

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[jscheffl]

@fbmatilla Can you atell me "why" you need this feature? I mean we have a lot of config options in the helm chart but adding more should have a reason as every additional config option drives complexity. Would only like to add complexity if there is a real "value", else might be good adding this on-top via Kustomize.

[fbmatilla]

@jscheffl look at this:

Now, Can you tell me "why" "you" added the same feature in the "create user "job"?

Sooooo, I guess I want to set up the cleanup job in the same way I'm doing with the create-user-job.

[jscheffl]

What I see is another {{- if condition that makes the chart more complex. And I was asking for a reason why this is needed. Code is not artwork where text need to be nice.

[Miretpl]

From my point of view, we could add it, as it is a matter of consistency within the helm chart (we already support that value for one job). In the future, when we remove complexity from the chart for those types of cases, the same approach will be used for all cases. I'm all-in for being extremely cautious of adding new features within the chart, but deprecations and/or new logic for improving consistency (this case), and by that being more user-friendly, I would allow.