Refactor VaultBackend to centralize secret path resolution and retrieval logic - #62643
Merged
Merged
Conversation
…ng logic Introduce a private helper to remove duplicated mount parsing, base path handling, and get_secret invocation across public methods.
boring-cyborg
Bot
added
area:providers
area:secrets
provider:hashicorp
Contributor
Author
|
Requesting review for this. |
potiuk
approved these changes
Mar 10, 2026
dominikhei
pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
…ng logic (apache#62643) Introduce a private helper to remove duplicated mount parsing, base path handling, and get_secret invocation across public methods. Co-authored-by: Sameer Mesiah <smesiah971@gmail.com>
Pyasma
pushed a commit
to Pyasma/airflow
that referenced
this pull request
Mar 13, 2026
…ng logic (apache#62643) Introduce a private helper to remove duplicated mount parsing, base path handling, and get_secret invocation across public methods. Co-authored-by: Sameer Mesiah <smesiah971@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored
VaultBackendto eliminate duplicated secret path resolution and secret retrieval logic acrossget_response,get_variable, andget_config. These methods previously repeated mount parsing, base path handling, path construction, and invocation of_VaultClient.get_secret.This change introduces a private helper that centralizes path resolution and secret fetching, while preserving the existing post-processing behavior in each public method.
Rationale
The previous implementation duplicated non-trivial mount parsing, path construction, and secret retrieval logic in three separate methods. Centralizing this logic reduces maintenance risk and prevents divergence between connection, variable, and config resolution paths. This refactor improves internal structure without altering semantics.
Tests
No new tests were added. Existing tests already validate mount handling, path resolution, and secret retrieval behavior.
Backwards Compatibility
No changes to public APIs or behavior. This is an internal refactor only.