Fix: Replace print with logger in Hive Hook kill method - #62990
Merged
Conversation
SameerMesiah97
left a comment
SameerMesiah97
left a comment
Contributor
There was a problem hiding this comment.
The change for hive is fine in isolation. But this PR has unrelated changes in the Open FaaS provider. Can you make a separate PR for that?
Signed-off-by: Ankit Kumar <ankitkumar17541@gmail.com>
Ironankit525
force-pushed
the
fix/hive-hook-logger
branch
from
March 8, 2026 10:32
efd4f4d to
56d5a13
Compare
Contributor
Author
|
Thanks for the review, @SameerMesiah97! I have removed the OpenFaaS changes from this branch (force-pushed) so this PR now only contains the Hive logger fix. The configurable OpenFaaS timeouts are now isolated and tracked in a separate PR here: #62731. |
potiuk
approved these changes
Mar 10, 2026
dominikhei
pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
Signed-off-by: Ankit Kumar <ankitkumar17541@gmail.com>
Pyasma
pushed a commit
to Pyasma/airflow
that referenced
this pull request
Mar 13, 2026
Signed-off-by: Ankit Kumar <ankitkumar17541@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During static analysis, I noticed that
print("Killing the Hive job")is being used rather than the standard Airflow structured logging inHiveCliHook.kill().This PR replaces
printwithself.log.infoso the message surfaces correctly in Airflow logs (e.g. Elasticsearch, CloudWatch, or local task logs) rather than bypassing it, making debugging job interruptions easier.Tests
Tested manually with existing tests via CI.