fix(providers/alibaba): pass relative path to oss_write in OSSRemoteLogIO.upload - #63246
Merged
Conversation
Member
|
Have you actually tested it with the actual service? |
Contributor
Author
|
No — unit tests only, no access to the Alibaba Cloud OSS service for integration testing. Happy to close this if someone with actual access can verify and take it over. |
Member
|
Maybve you can look at history of changes and ping someone who can verify it ? |
Contributor
Author
|
Checked git history — @Tushar4432 has contributed to the Alibaba provider. Could you verify this fix against a live OSS environment? |
Member
|
Yeah. Would be good to verify @Tushar4432 |
potiuk
added
the
ready for maintainer review
YoannAbriel
force-pushed
the
fix/issue-63242
branch
4 times, most recently
from
March 14, 2026 13:07
7396eda to
5116066
Compare
Contributor
|
@alifaz31 as the issue reporter - can you check the fix and confirm if it's resolve the problem? |
YoannAbriel
force-pushed
the
fix/issue-63242
branch
2 times, most recently
from
March 23, 2026 13:09
ea63c29 to
63d5311
Compare
…ogIO.upload upload() was passing the full OSS URI (built with remote_base prefix) to oss_write(), which prepends base_folder internally, producing a doubled path like oss://bucket/prefix/oss://bucket/prefix/dag_id=.../attempt=1.log. Pass only the relative path so oss_write() constructs the correct key. Closes: apache#63242
YoannAbriel
force-pushed
the
fix/issue-63242
branch
from
March 23, 2026 19:07
63d5311 to
9155d26
Compare
eladkal
approved these changes
Mar 24, 2026
2 tasks
vatsrahul1001
pushed a commit
that referenced
this pull request
Mar 25, 2026
…ogIO.upload (#63246) upload() was passing the full OSS URI (built with remote_base prefix) to oss_write(), which prepends base_folder internally, producing a doubled path like oss://bucket/prefix/oss://bucket/prefix/dag_id=.../attempt=1.log. Pass only the relative path so oss_write() constructs the correct key. Closes: #63242
aaron-y-chen
pushed a commit
to aaron-y-chen/airflow
that referenced
this pull request
Mar 30, 2026
…ogIO.upload (apache#63246) upload() was passing the full OSS URI (built with remote_base prefix) to oss_write(), which prepends base_folder internally, producing a doubled path like oss://bucket/prefix/oss://bucket/prefix/dag_id=.../attempt=1.log. Pass only the relative path so oss_write() constructs the correct key. Closes: apache#63242
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
…ogIO.upload (apache#63246) upload() was passing the full OSS URI (built with remote_base prefix) to oss_write(), which prepends base_folder internally, producing a doubled path like oss://bucket/prefix/oss://bucket/prefix/dag_id=.../attempt=1.log. Pass only the relative path so oss_write() constructs the correct key. Closes: apache#63242
abhijeets25012-tech
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Apr 9, 2026
…ogIO.upload (apache#63246) upload() was passing the full OSS URI (built with remote_base prefix) to oss_write(), which prepends base_folder internally, producing a doubled path like oss://bucket/prefix/oss://bucket/prefix/dag_id=.../attempt=1.log. Pass only the relative path so oss_write() constructs the correct key. Closes: apache#63242
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OSSRemoteLogIO.upload()passes a full OSS URI tooss_write(), which internally prependsbase_folderagain. This produces malformed keys likeprefix/logs/oss://bucket/prefix/logs/dag_id=.../attempt=1.log, making logs unreadable from the Airflow UI.Root Cause
upload()joinsself.remote_base(the fulloss://bucket/prefixURI) with the relative path, then passes the result tooss_write(). Butoss_write()already prependsself.base_folder(extracted fromremote_base), so the prefix gets doubled.Fix
Pass only the relative path (relative to
base_log_folder) tooss_write()instead of the full OSS URI. Added a test to verify both absolute and relative input paths produce the correct relative argument tooss_write().Closes: #63242
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.