Skip to content

Enable TLS Certificate Verification for K8s Token Exchange in Databricks Hook - #63704

Merged
eladkal merged 12 commits into
apache:mainfrom
mwojtyczka:cert_verification
Mar 17, 2026
Merged

Enable TLS Certificate Verification for K8s Token Exchange in Databricks Hook#63704
eladkal merged 12 commits into
apache:mainfrom
mwojtyczka:cert_verification

Conversation

@mwojtyczka

Copy link
Copy Markdown
Contributor

Enable Databricks hook TLS verification when communicating with the Kubernetes API server during federated token exchange.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below) Claude Code

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@eladkal eladkal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have test coverage for this change in /providers/databricks/tests/unit/databricks/hooks/test_databricks_base.py

@mwojtyczka

Copy link
Copy Markdown
Contributor Author

Would be nice to have test coverage for this change in /providers/databricks/tests/unit/databricks/hooks/test_databricks_base.py

Added unit tests

@potiuk

potiuk commented Mar 16, 2026

Copy link
Copy Markdown
Member

Pending unit tests fixing of course :)

@mwojtyczka

Copy link
Copy Markdown
Contributor Author

Pending unit tests fixing of course :)

Thanks! fixed tests, we should be good now

@jscheffl

Copy link
Copy Markdown
Contributor

Pending unit tests fixing of course :)

Thanks! fixed tests, we should be good now

If you seek for spelling error in docs build logs:
image

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small spelling nit, else LGTM!

@mwojtyczka

Copy link
Copy Markdown
Contributor Author

Small spelling nit, else LGTM!

spelling fixed

@jscheffl

Copy link
Copy Markdown
Contributor

Now just fighting against CI erros we had earlier...

@mwojtyczka

mwojtyczka commented Mar 17, 2026

Copy link
Copy Markdown
Contributor Author

Now just fighting against CI erros we had earlier...

There is just one last error, but it does not seem to be related to my changes:

providers/common/ai/src/airflow/providers/common/ai/utils/sql_validation.py:84: error: List comprehension has incompatible type List[Expr]; expected List[Expression]  [misc]
          parsed: list[exp.Expression] = [s for s in statements if s is not None]
                                          ^
  Found 1 error in 1 file (checked 4272 source files)

@eladkal
eladkal merged commit a8c1206 into apache:main Mar 17, 2026
91 of 92 checks passed
fat-catTW pushed a commit to fat-catTW/airflow that referenced this pull request Mar 22, 2026
…icksHook` (apache#63704)

* Enable  TLS Certificate Verification for K8s Token Exchange

* added unit tests

* fixed tests

* refactor tests

* added change log

* fixed spelling typo

* updated changelog

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
techcodie pushed a commit to techcodie/airflow that referenced this pull request Mar 23, 2026
…icksHook` (apache#63704)

* Enable  TLS Certificate Verification for K8s Token Exchange

* added unit tests

* fixed tests

* refactor tests

* added change log

* fixed spelling typo

* updated changelog

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
abhijeets25012-tech pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Apr 9, 2026
…icksHook` (apache#63704)

* Enable  TLS Certificate Verification for K8s Token Exchange

* added unit tests

* fixed tests

* refactor tests

* added change log

* fixed spelling typo

* updated changelog

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants